Skip to content

gh-109653: Improve import time of importlib.metadata / email.utils #114664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-109653: Improve import time of importlib.metadata / email.utils
My criterion for delayed imports is that they're only worth it if the
majority of users of the module would benefit from it, otherwise you're
just moving latency around unpredictably.

mktime_tz is not used anywhere in the standard library and grep.app
indicates it's not got much use in the ecosystem either.

Distribution.files is not nearly as widely used as other
importlib.metadata APIs, so we defer the csv import.

Before:
```
λ hyperfine -w 8 './python -c "import importlib.metadata"'
Benchmark 1: ./python -c "import importlib.metadata"
  Time (mean ± σ):      65.1 ms ±   0.5 ms    [User: 55.3 ms, System: 9.8 ms]
  Range (min … max):    64.4 ms …  66.4 ms    44 runs
```

After:
```
λ hyperfine -w 8 './python -c "import importlib.metadata"'
Benchmark 1: ./python -c "import importlib.metadata"
  Time (mean ± σ):      62.0 ms ±   0.3 ms    [User: 52.5 ms, System: 9.6 ms]
  Range (min … max):    61.3 ms …  62.8 ms    46 runs
```

for about a 3ms saving with warm disk cache, maybe 7-11ms with cold disk
cache.
  • Loading branch information
hauntsaninja committed Jan 28, 2024
commit 579644ade04cdba3d0fdabe84b55b51e2ed64b45
4 changes: 3 additions & 1 deletion Lib/email/_parseaddr.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'quote',
]

import time, calendar
import time

SPACE = ' '
EMPTYSTRING = ''
Expand Down Expand Up @@ -194,6 +194,8 @@ def mktime_tz(data):
# No zone info, so localtime is better assumption than GMT
return time.mktime(data[:8] + (-1,))
else:
import calendar

t = calendar.timegm(data)
return t - data[9]

Expand Down
3 changes: 2 additions & 1 deletion Lib/importlib/metadata/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
import re
import abc
import csv
import sys
import json
import email
Expand Down Expand Up @@ -478,6 +477,8 @@ def make_file(name, hash=None, size_str=None):

@pass_none
def make_files(lines):
import csv

return starmap(make_file, csv.reader(lines))

@pass_none
Expand Down