Skip to content

gh-114685: Fix incorrect use of PyBUF_READ in import.c #114686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

gh-114685: Fix incorrect use of PyBUF_READ in import.c #114686

merged 1 commit into from
Jan 29, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 28, 2024 •
edited by bedevere-app bot
Loading

It looks like a typo to me, so no NEWS entry.

@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2024
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 1ac1b2f into python:main Jan 29, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 29, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2024
@sobolevn @miss-islington
pythongh-114685: Fix incorrect use of PyBUF_READ in import.c (pythonG…
6fecdaf 
…H-114686)

(cherry picked from commit 1ac1b2f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2024
@sobolevn @miss-islington
pythongh-114685: Fix incorrect use of PyBUF_READ in import.c (pythonG…
432bfcf 
…H-114686)

(cherry picked from commit 1ac1b2f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2024

GH-114700 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2024

GH-114701 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 29, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 29, 2024
@miss-islington @sobolevn
[3.11] gh-114685: Fix incorrect use of PyBUF_READ in import.c (GH-114686
ee3ca96 
) (GH-114701)

(cherry picked from commit 1ac1b2f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
serhiy-storchaka pushed a commit that referenced this pull request Jan 29, 2024
@miss-islington @sobolevn
[3.12] gh-114685: Fix incorrect use of PyBUF_READ in import.c (GH-114686
2a1d2c8 
) (GH-114700)

(cherry picked from commit 1ac1b2f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-114685: Fix incorrect use of PyBUF_READ in import.c (pythonG…
27019bc 
…H-114686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @serhiy-storchaka