Skip to content

gh-114569: Use PyMem_* APIs for non-PyObjects in unicodeobject.c #114690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

gh-114569: Use PyMem_* APIs for non-PyObjects in unicodeobject.c #114690

merged 1 commit into from
Jan 29, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 28, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2024
Closed
@erlend-aasland erlend-aasland linked an issue Jan 28, 2024 that may be closed by this pull request
Do not allocate non-PyObjects with PyObject_Malloc() #114569
Closed
@erlend-aasland erlend-aasland removed a link to an issue Jan 28, 2024
Do not allocate non-PyObjects with PyObject_Malloc() #114569
Closed
colesbury
colesbury approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erlend-aasland erlend-aasland merged commit 53d921e into python:main Jan 29, 2024
@erlend-aasland erlend-aasland deleted the nogil/pyobject-malloc-unicodeobject.c branch January 29, 2024 20:48
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

@erlend-aasland erlend-aasland linked an issue Jan 29, 2024 that may be closed by this pull request
Do not allocate non-PyObjects with PyObject_Malloc() #114569
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@erlend-aasland @aisk
pythongh-114569: Use PyMem_* APIs for non-PyObjects in unicodeobject.c (
11cd907 
python#114690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not allocate non-PyObjects with PyObject_Malloc()
2 participants
@erlend-aasland @colesbury