Skip to content

bpo-35397: Remove deprecation and document urllib.parse.unwrap #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2019

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Jan 9, 2019

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.Open trigger

@merwok merwok changed the title bpo-35397: Remove deprecation and document urllib.parse.unwrap() bpo-35397: Remove deprecation and document urllib.parse.unwrap Jan 10, 2019
@csabella
Copy link
Contributor

@remilapeyre, please apply the change suggested by @merwok. Thanks!

Co-Authored-By: Éric Araujo <merwok@netwok.org>
@remilapeyre
Copy link
Contributor Author

Thanks @csabella, it's done !

@csabella
Copy link
Contributor

@remilapeyre, the builds are failing because of the new documentation you added to the .rst file for unwrap. It is seeing it as 'suspicious' markup. Here is the output of the failure:

Warning, treated as error:
[library/urllib.parse:379] ":scheme" found in "<URL:scheme://host/path>"
Makefile:44: recipe for target 'build' failed
make[1]: *** [build] Error 2
make[1]: Leaving directory '/home/travis/build/python/cpython/Doc'
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.
Makefile:105: recipe for target 'suspicious' failed

So, based on the suggestion there, you need to edit susp-ignored.csv in https://github.com/python/cpython/tree/master/Doc/tools. Here's a link to the checks, for more info.

@remilapeyre
Copy link
Contributor Author

Thanks @csabella, this is now fixed.

@csabella csabella merged commit 674ee12 into python:master May 27, 2019
@csabella
Copy link
Contributor

@remilapeyre, thank you for the contribution! @merwok, thank you for the review! 🎉

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants