Skip to content

gh-112087: Make list_{count, index, contains} to be thread-safe. #114916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2024
Merged

gh-112087: Make list_{count, index, contains} to be thread-safe. #114916

merged 4 commits into from
Feb 6, 2024
+33 −19

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 2, 2024 •
edited by bedevere-app bot
Loading

@corona10 corona10 requested review from DinoV and colesbury February 2, 2024 15:21
@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2024
Closed
4 tasks
@corona10
Copy link
Member Author

corona10 commented Feb 2, 2024 •
edited
Loading

Once the #114843 is merged, I will migrate APIs that both atomic operations and PyList_GetItemRef is needed.

@corona10 corona10 marked this pull request as ready for review February 2, 2024 15:42
colesbury
colesbury reviewed Feb 2, 2024
View reviewed changes
@corona10 corona10 requested a review from colesbury February 3, 2024 10:04
colesbury
colesbury reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the naming of _PyList_GetItemRef.

@corona10 corona10 requested a review from colesbury February 6, 2024 02:07
@corona10 corona10 mentioned this pull request Feb 6, 2024
Merged
colesbury
colesbury approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 enabled auto-merge (squash) February 6, 2024 16:01
@corona10 corona10 merged commit f7a22a7 into python:main Feb 6, 2024
@corona10 corona10 deleted the gh-112087-fetch branch February 7, 2024 06:50
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@corona10 @fsc-eriker
pythongh-112087: Make list_{count, index, contains} to be thread-safe. (
6280734 
pythongh-114916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@DinoV DinoV Awaiting requested review from DinoV

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @colesbury