Skip to content

gh-115256: Remove refcycles from tarfile writing #115257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024
Merged

gh-115256: Remove refcycles from tarfile writing #115257

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7997388
remove refcycles from tarfile writing
pan324 Feb 10, 2024
d927931
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 10, 2024
de2eb93
added DeprecationWarning
pan324 Feb 18, 2024
af3a422
fixed rst
pan324 Feb 18, 2024
54005df
fixed rst
pan324 Feb 18, 2024
5cf1858
Mention this in What's New
encukou Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed rst
  • Loading branch information
@pan324
pan324 committed Feb 18, 2024
commit af3a42232fd7b3460e432fa653740d3cf9896dfc
6 changes: 5 additions & 1 deletion Misc/NEWS.d/next/Library/2024-02-10-17-18-49.gh-issue-115256.41Fy9P.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
Added DeprecationWarning when accessing the tarfile attribute of TarInfo objects. The attribute is never used internally and is only attached to TarInfos when the tarfile is opened in write-mode, not read-mode. The attribute creates an unnecessary reference cycle which may cause corruption when not closing the handle after writing a tarfile.
Added DeprecationWarning when accessing the tarfile attribute of TarInfo
objects. The attribute is never used internally and is only attached to
TarInfos when the tarfile is opened in write-mode, not read-mode. The
attribute creates an unnecessary reference cycle which may cause
corruption when not closing the handle after writing a tarfile.