Skip to content

[3.11] gh-114563: C decimal falls back to pydecimal for unsupported format strings (GH-114879) #115384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

belm0
Copy link
Contributor

@belm0 belm0 commented Feb 13, 2024

Immediate merits:

  • eliminate complex workarounds for 'z' format support (NOTE: mpdecimal recently added 'z' support, so this becomes efficient in the long term.)
  • fix 'z' format memory leak
  • fix 'z' format applied to 'F'
  • fix missing 'GH-' format support

Suggested and prototyped by Stefan Krah.

Fixes gh-114563, gh-91060

(cherry picked from commit 72340d1)

…unsupported format strings (pythonGH-114879) (pythonGH-115353)

Immediate merits:
* eliminate complex workarounds for 'z' format support
  (NOTE: mpdecimal recently added 'z' support, so this becomes
  efficient in the long term.)
* fix 'z' format memory leak
* fix 'z' format applied to 'F'
* fix missing 'GH-' format support

Suggested and prototyped by Stefan Krah.

Fixes pythongh-114563, pythongh-91060

(cherry picked from commit 72340d1)

(cherry picked from commit 09c98e4)

Co-authored-by: John Belmonte <john@neggie.net>
Co-authored-by: Stefan Krah <skrah@bytereef.org>
@belm0 belm0 requested a review from rhettinger as a code owner February 13, 2024 04:15
@belm0 belm0 changed the title [3.11] gh-114563: C decimal falls back to pydecimal for unsupported format strings (GH-114879) (GH-115353) [3.11] gh-114563: C decimal falls back to pydecimal for unsupported format strings (GH-114879) Feb 13, 2024
@serhiy-storchaka serhiy-storchaka merged commit b86fdf2 into python:3.11 Feb 13, 2024
@belm0 belm0 deleted the backport-09c98e4-3.11 branch February 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants