Skip to content

gh-115383: Install ncurses in reusable macos workflow #115389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 13, 2024

@sobolevn
Copy link
Member Author

sobolevn commented Feb 13, 2024

It, obviously, didn't help :(
Broken build: https://github.com/python/cpython/actions/runs/7882893355/job/21508865500?pr=115389

@sobolevn sobolevn closed this Feb 13, 2024
@ned-deily
Copy link
Member

@sobolevn, See the Install Homebrew Dependencies section of the workflow log. Just installing ncurses from Homebrew isn't enough because Homebrew ncurses is keg-only:

For pkg-config to find ncurses you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/ncurses/lib/pkgconfig"

@ned-deily
Copy link
Member

And, of course, Homebrew uses different install paths for Intel Mac systems and Apple Silicon Mac systems so perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate from the devguide recipe.

@sobolevn sobolevn reopened this Feb 13, 2024
@sobolevn
Copy link
Member Author

We can continue to experiment here :)

@ambv
Copy link
Contributor

ambv commented Feb 13, 2024

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

@erlend-aasland
Copy link
Contributor

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

That would be CURSES_CFLAGS and CURSES_LIBS.

$ ./configure --help| grep -i curses
  CURSES_CFLAGS
              C compiler flags for CURSES, overriding pkg-config
  CURSES_LIBS linker flags for CURSES, overriding pkg-config

@ned-deily
Copy link
Member

ned-deily commented Feb 13, 2024

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

That would be CURSES_CFLAGS and CURSES_LIBS.

$ ./configure --help| grep -i curses
  CURSES_CFLAGS
              C compiler flags for CURSES, overriding pkg-config
  CURSES_LIBS linker flags for CURSES, overriding pkg-config

Yeah, I meant adapting the devguide's GDBM_CFLAGS and GDBM_LIBS recipe for CURSES_FLAGS and CURSES_LIBS but, as it appears the root causes were actually a caching issue and using a newer Apple SDK on an older system, that we shouldn't need to use the Homebrew ncurses going forward so this can probably safely be closed.

@sobolevn sobolevn closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants