Skip to content

docs: use consistent .append() in dis.rst #115434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Feb 13, 2024

The STACK variable is described as like a Python list, so pushing to it should be done with .append() consistently throughout.

As discussed at https://discuss.python.org/t/dis-py-stack-append-vs-stack-push/45330


📚 Documentation preview 📚: https://cpython-previews--115434.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 13, 2024
@nedbat nedbat requested a review from terryjreedy February 13, 2024 23:53
@terryjreedy terryjreedy merged commit 4742047 into python:main Feb 15, 2024
@terryjreedy
Copy link
Member

The only instance of .push in 3.12 is the one before The operand determines which intrinsic function is called:. None in 3.11 doc. Not worth the backport hassle to me, but I would merge a backport if submitted and say how to do it if asked.

@nedbat nedbat deleted the nedbat/stack.append branch February 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants