Skip to content

gh-115942: Add locked to several multiprocessing locks #115944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 8, 2025
Merged

gh-115942: Add locked to several multiprocessing locks #115944

merged 10 commits into from
Apr 8, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 26, 2024 •
edited
Loading

TODO:

  • Get field-expert's approval
  • Docs
  • News

@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2024
Closed
@sobolevn sobolevn marked this pull request as ready for review March 13, 2024 06:44
@sobolevn sobolevn requested a review from gpshead as a code owner March 13, 2024 06:44
@sobolevn
Copy link
Member Author

sobolevn commented Jun 3, 2024

@gpshead do you have an opinion about this? :)

@sobolevn
Copy link
Member Author

friendly ping @gpshead

mpage
mpage reviewed Jun 21, 2024
View reviewed changes
@sobolevn @mpage
Update Modules/_threadmodule.c
646c650 
Co-authored-by: mpage <mpage@cs.stanford.edu>
vstinner
vstinner reviewed Mar 13, 2025
View reviewed changes
@gpshead
Copy link
Member

gpshead commented Mar 13, 2025

FWIW this PR makes sense to me.

@sobolevn
Copy link
Member Author

Ok, then I will add all the missing details. Thanks a lot! 👍

vstinner
vstinner reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests on threading.RLock.locked().

picnixz
picnixz reviewed Apr 1, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some rewording. Otherwise, once tests requested by Victor are added, LGTM.

@sobolevn
Copy link
Member Author

sobolevn commented Apr 1, 2025

@vstinner @gpshead this is now ready to be reviewed :)

@sobolevn sobolevn requested review from vstinner and mpage April 1, 2025 09:43
picnixz
picnixz approved these changes Apr 1, 2025
View reviewed changes
vstinner
vstinner approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hugovk
hugovk reviewed Apr 7, 2025
View reviewed changes
@sobolevn @hugovk
Apply suggestions from code review
1a50a20 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead
gpshead approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I could object to this being a locked() method instead of a .locked property... but this is matching an existing ancient API on purpose so... LGTM.

@sobolevn sobolevn merged commit f7305a0 into python:main Apr 8, 2025
42 checks passed
@sobolevn
Copy link
Member Author

sobolevn commented Apr 8, 2025

Thanks everyone! 🎉

@YvesDup YvesDup mentioned this pull request Apr 15, 2025
Closed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@sobolevn @mpage
@hugovk @seehwan80
pythongh-115942: Add locked to several multiprocessing locks (pytho…
43c634e 
…n#115944)

Co-authored-by: mpage <mpage@cs.stanford.edu>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@YvesDup YvesDup mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@gpshead gpshead gpshead approved these changes

@vstinner vstinner vstinner approved these changes

@picnixz picnixz picnixz approved these changes

@mpage mpage Awaiting requested review from mpage

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @gpshead @vstinner @mpage @hugovk @picnixz