Skip to content

chg: ⚡ optimize Future's read only method by removing useless con… #115951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −6
Open

chg: ⚡ optimize Future's read only method by removing useless con… #115951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77fbd8e
chg: :zap: optimize Future's read only method by removing useless con…
bashirmindee Feb 26, 2024
ca9dca8
Merge branch 'main' into faster-Future-access
bashirmindee Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Lib/concurrent/futures/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,18 +382,15 @@ def cancel(self):

def cancelled(self):
"""Return True if the future was cancelled."""
with self._condition:
return self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]
return self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]

def running(self):
"""Return True if the future is currently executing."""
with self._condition:
return self._state == RUNNING
return self._state == RUNNING

def done(self):
"""Return True if the future was cancelled or finished executing."""
with self._condition:
return self._state in [CANCELLED, CANCELLED_AND_NOTIFIED, FINISHED]
return self._state in [CANCELLED, CANCELLED_AND_NOTIFIED, FINISHED]

def __get_result(self):
if self._exception:
Expand Down