Skip to content

gh-115997: Make HTTPResponse.read1 and readline raise IncompleteRead #115998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-115997: Make HTTPResponse.read1 and readline raise IncompleteRead #115998

wants to merge 13 commits into from

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Feb 27, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2024
Open
@illia-v
Copy link
Contributor Author

illia-v commented Mar 27, 2024

@serhiy-storchaka could you please take a look at this PR? It's similar to #113199

vadmium
vadmium reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes would be better than nothing, but I hope my suggestion would also fix the case of readline with an incomplete line

@illia-v
Copy link
Contributor Author

illia-v commented Feb 10, 2025

Current changes would be better than nothing, but I hope my suggestion would also fix the case of readline with an incomplete line

@vadmium please check if my last changes fix the case

@illia-v illia-v requested a review from vadmium February 10, 2025 21:09
vadmium
vadmium reviewed Mar 30, 2025
View reviewed changes
Copy link
Member

@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only looked at the changes, not tried running them. They look worthwhile to me, although there is room for improving the tests.

@illia-v illia-v requested a review from vadmium April 1, 2025 17:49
@vadmium
Copy link
Member

vadmium commented Apr 1, 2025

Looks okay to me

@illia-v
Copy link
Contributor Author

illia-v commented Apr 2, 2025

Looks okay to me

@vadmium thank you for the review! Do you think it can be merged before 3.14's betas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium Awaiting requested review from vadmium

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illia-v @vadmium