gh-116042: Fix location for SyntaxErrors of invalid escapes in the tokenizer #116049
+80
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pablogsal
commented
Feb 28, 2024
•
- Issue: Span for invalid escape sequence in multiline strings is wrong #116042
AlexWaygood
reviewed
Feb 28, 2024
lysnikolaou
approved these changes
Feb 29, 2024
|
When excessive quotes are present, the error highlight has offset. I suggest to add this test-case as well. "''Incorrect \ logic?"
^^
SyntaxError: invalid escape sequence '\ 'and "'''''''''''''''''''''invalid\ Escape"
^
SyntaxError: invalid escape sequence '\ 'while it works well with single and multiple normal quotes "Incorrect \ logic?"
^^
SyntaxError: invalid escape sequence '\ ' |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
Sorry, @pablogsal, I could not cleanly backport this to |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Feb 13, 2025
…pes in the tokenizer (pythonGH-116049) (cherry picked from commit 56eda25) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-130065 is a backport of this pull request to the 3.12 branch. |
|
GH-130066 is a backport of this pull request to the 3.13 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Feb 13, 2025
…pes in the tokenizer (pythonGH-116049) (cherry picked from commit 56eda25) (cherry picked from commit 369704b) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Feb 13, 2025
pablogsal
added a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.