Skip to content

gh-116035: Document that both tzinfo and fold are ignored in comparisons if tzinfo is the same #116187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

gh-116035: Document that both tzinfo and fold are ignored in comparisons if tzinfo is the same #116187

merged 1 commit into from
Mar 1, 2024
+8 −2

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 1, 2024 •
edited by github-actions bot
Loading

Although it looks like a bug to me.

📚 Documentation preview 📚: https://cpython-previews--116187.org.readthedocs.build/

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 1, 2024
@serhiy-storchaka serhiy-storchaka requested a review from tim-one March 1, 2024 09:16
@bedevere-app bedevere-app bot mentioned this pull request Mar 1, 2024
Open
@tim-one tim-one self-assigned this Mar 1, 2024
tim-one
tim-one approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For historical clarity, it would help if the check-in message noted that this mostly restores information that was mistakenly removed earlier.

@serhiy-storchaka serhiy-storchaka merged commit 05b0490 into python:main Mar 1, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-datetime-comparizons-same-tzinfo branch March 1, 2024 17:16
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2024
@serhiy-storchaka @miss-islington
pythongh-116035: Document that both tzinfo and fold are ignored in co…
eaf2b68 
…mparisons if tzinfo is the same (pythonGH-116187)

This mostly restores information removed in c12240e (pythonGH-114749).
(cherry picked from commit 05b0490)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2024
@serhiy-storchaka @miss-islington
pythongh-116035: Document that both tzinfo and fold are ignored in co…
94e375b 
…mparisons if tzinfo is the same (pythonGH-116187)

This mostly restores information removed in c12240e (pythonGH-114749).
(cherry picked from commit 05b0490)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 1, 2024

GH-116216 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 1, 2024

GH-116217 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 1, 2024
serhiy-storchaka added a commit that referenced this pull request Mar 1, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-116035: Document that both tzinfo and fold are ignored in c…
16be4a3 
…omparisons if tzinfo is the same (GH-116187) (GH-116216)

This mostly restores information removed in c12240e (GH-114749).
(cherry picked from commit 05b0490)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 1, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-116035: Document that both tzinfo and fold are ignored in c…
ac8d995 
…omparisons if tzinfo is the same (GH-116187) (GH-116217)

This mostly restores information removed in c12240e (GH-114749).
(cherry picked from commit 05b0490)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@serhiy-storchaka @woodruffw
pythongh-116035: Document that both tzinfo and fold are ignored in co…
efc14d8 
…mparisons if tzinfo is the same (pythonGH-116187)

This mostly restores information removed in c12240e (pythonGH-114749).
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@serhiy-storchaka @adorilson
pythongh-116035: Document that both tzinfo and fold are ignored in co…
89fc56e 
…mparisons if tzinfo is the same (pythonGH-116187)

This mostly restores information removed in c12240e (pythonGH-114749).
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-116035: Document that both tzinfo and fold are ignored in co…
b4f992a 
…mparisons if tzinfo is the same (pythonGH-116187)

This mostly restores information removed in c12240e (pythonGH-114749).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-one tim-one tim-one approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

@tim-one tim-one

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @tim-one