Skip to content

gh-116127: PEP-705: Add ReadOnly support for TypedDict #116350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 5, 2024

All the credit for this change goes to the original authors of python/typing_extensions@0b0166d (in the same order as GitHub shows it):

My extra change is that get_type_hints(include_extras=False) now removes ReadOnly special form. See python/typing_extensions#349 backport PR for typing-extensions.


📚 Documentation preview 📚: https://cpython-previews--116350.org.readthedocs.build/

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this to What's New?

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some wording suggestions.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra merged commit df4784b into python:main Mar 12, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…hon#116350)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…hon#116350)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants