Skip to content

gh-116600: [Enum] fix global Flag repr #116615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2024
Merged

gh-116600: [Enum] fix global Flag repr #116615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0f2588
[Enum] fix global flag repr
ethanfurman Mar 11, 2024
fed8ce8
Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.F…
ethanfurman Mar 11, 2024
358d815
Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.F…
ethanfurman Mar 11, 2024
54e803a
Fix backticks
Eclips4 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,7 +1682,7 @@ def global_flag_repr(self):
cls_name = self.__class__.__name__
if self._name_ is None:
return "%s.%s(%r)" % (module, cls_name, self._value_)
if _is_single_bit(self):
if _is_single_bit(self._value_):
return '%s.%s' % (module, self._name_)
if self._boundary_ is not FlagBoundary.KEEP:
return '|'.join(['%s.%s' % (module, name) for name in self.name.split('|')])
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4067,6 +4067,8 @@ def test_global_repr_conform1(self):

@reraise_if_not_enum(NoName)
def test_global_enum_str(self):
self.assertEqual(repr(NoName.ONE), 'test_enum.ONE')
self.assertEqual(repr(NoName(0)), 'test_enum.NoName(0)')
self.assertEqual(str(NoName.ONE & NoName.TWO), 'NoName(0)')
self.assertEqual(str(NoName(0)), 'NoName(0)')

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :func:`repr` for global :class:`~enum.Flag` members.