[3.11] gh-110819: Fix ‘kind’ may be used uninitialized warning in longobject (GH-116599)
#116650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2024
|
This did not go well, there are extra files. I will recreate the PR. Sorry, this is |
…in `longobject` (pythonGH-116599) (cherry picked from commit eb947cd) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
d6db610 to
3651286
Compare
|
Here we go, only a single file is left changed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit eb947cd)
Note the change: on 3.11
kindis defined asenum PyUnicode_Kind: https://github.com/python/cpython/blob/3.11/Objects/longobject.c#L1938C5-L1938C24 So, I've changedint kindto beenum PyUnicode_Kindas it used to be.maybe-uninitializedcompiler warnings onlong_format_binaryandlong_to_decimal_string_internal#110819