Skip to content

[3.11] gh-116491: Improve test_win32_ver (GH-116506) #116709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[3.11] gh-116491: Improve test_win32_ver (GH-116506) #116709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion Lib/test/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,36 @@ def test_java_ver(self):
if sys.platform == 'java':
self.assertTrue(all(res))

@unittest.skipUnless(support.MS_WINDOWS, 'This test only makes sense on Windows')
def test_win32_ver(self):
res = platform.win32_ver()
release1, version1, csd1, ptype1 = 'a', 'b', 'c', 'd'
res = platform.win32_ver(release1, version1, csd1, ptype1)
self.assertEqual(len(res), 4)
release, version, csd, ptype = res
if release:
# Currently, release names always come from internal dicts,
# but this could change over time. For now, we just check that
# release is something different from what we have passed.
self.assertNotEqual(release, release1)
if version:
# It is rather hard to test explicit version without
# going deep into the details.
self.assertIn('.', version)
for v in version.split('.'):
int(v) # should not fail
if csd:
self.assertTrue(csd.startswith('SP'), msg=csd)
if ptype:
if os.cpu_count() > 1:
self.assertIn('Multiprocessor', ptype)
else:
self.assertIn('Uniprocessor', ptype)

@unittest.skipIf(support.MS_WINDOWS, 'This test only makes sense on non Windows')
def test_win32_ver_on_non_windows(self):
release, version, csd, ptype = 'a', '1.0', 'c', 'd'
res = platform.win32_ver(release, version, csd, ptype)
self.assertSequenceEqual(res, (release, version, csd, ptype), seq_type=tuple)

def test_mac_ver(self):
res = platform.mac_ver()
Expand Down