Skip to content

gh-117089: Move importlib.metadata tests to their own package #117092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2024
Merged

gh-117089: Move importlib.metadata tests to their own package #117092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3efc6e
Ensure importlib.metadata tests do not leak references in sys.modules.
jaraco Mar 20, 2024
20d8f3a
Move importlib.metadata tests to their own package for easier syncing…
jaraco Mar 20, 2024
78feda7
Update owners and makefile for new directories.
jaraco Mar 20, 2024
79cc84e
Add blurb
jaraco Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Python/dynload_*.c @ericsnowcurrently
Lib/test/test_module/ @ericsnowcurrently
Doc/c-api/module.rst @ericsnowcurrently
**/*importlib/resources/* @jaraco @warsaw @FFY00
**/importlib/metadata/* @jaraco @warsaw
**/*importlib/metadata/* @jaraco @warsaw

# Dates and times
**/*datetime* @pganssle @abalkin
Expand Down
0 Lib/test/test_importlib/data/__init__.py → Lib/test/test_importlib/metadata/__init__.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/test_importlib/_context.py → Lib/test/test_importlib/metadata/_context.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/test_importlib/_path.py → Lib/test/test_importlib/metadata/_path.py
View file
Open in desktop
File renamed without changes.
Empty file added Lib/test/test_importlib/metadata/data/__init__.py
View file
Open in desktop
Empty file.
0 ...rtlib/data/example-21.12-py3-none-any.whl → ...adata/data/example-21.12-py3-none-any.whl
View file
Open in desktop
File renamed without changes.
0 ...st_importlib/data/example-21.12-py3.6.egg → ...lib/metadata/data/example-21.12-py3.6.egg
View file
Open in desktop
File renamed without changes.
0 ...tlib/data/example2-1.0.0-py3-none-any.whl → ...data/data/example2-1.0.0-py3-none-any.whl
View file
Open in desktop
File renamed without changes.
4 changes: 3 additions & 1 deletion Lib/test/test_importlib/fixtures.py → Lib/test/test_importlib/metadata/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import functools
import contextlib

from test.support import import_helper
from test.support.os_helper import FS_NONASCII
from test.support import requires_zlib

Expand Down Expand Up @@ -85,6 +86,7 @@ def add_sys_path(dir):
def setUp(self):
super().setUp()
self.fixtures.enter_context(self.add_sys_path(self.site_dir))
self.fixtures.enter_context(import_helper.isolated_modules())


class SiteBuilder(SiteDir):
Expand Down Expand Up @@ -348,7 +350,7 @@ def DALS(str):

@requires_zlib()
class ZipFixtures:
root = 'test.test_importlib.data'
root = 'test.test_importlib.metadata.data'

def _fixture_on_path(self, filename):
pkg_file = resources.files(self.root).joinpath(filename)
Expand Down
0 Lib/test/test_importlib/stubs.py → Lib/test/test_importlib/metadata/stubs.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/test_importlib/test_metadata_api.py → Lib/test/test_importlib/metadata/test_api.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/test_importlib/test_main.py → ...test/test_importlib/metadata/test_main.py
View file
Open in desktop
File renamed without changes.
0 Lib/test/test_importlib/test_zip.py → Lib/test/test_importlib/metadata/test_zip.py
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,10 +2351,11 @@ TESTSUBDIRS= idlelib/idle_test \
test/test_import/data/unwritable \
test/test_importlib \
test/test_importlib/builtin \
test/test_importlib/data \
test/test_importlib/extension \
test/test_importlib/frozen \
test/test_importlib/import_ \
test/test_importlib/metadata \
test/test_importlib/metadata/data \
test/test_importlib/namespace_pkgs \
test/test_importlib/namespace_pkgs/both_portions \
test/test_importlib/namespace_pkgs/both_portions/foo \
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2024-03-20-14-19-32.gh-issue-117089.WwR1Z1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Consolidated tests for importlib.metadata in their own ``metadata`` package.
Loading