Skip to content

gh-117518: Add PyTuple_GetItemRef() function #117519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-117518: Add PyTuple_GetItemRef() function #117519

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 3, 2024 •
edited
Loading

Replace Py_NewRef(PyTuple_GET_ITEM(tuple, pos)) with PyTuple_GetItemRef(tuple, pos).

📚 Documentation preview 📚: https://cpython-previews--117519.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Apr 3, 2024
Closed
@vstinner
pythongh-117518: Add PyTuple_GetItemRef() function
a2ead7e 
Replace Py_NewRef(PyTuple_GET_ITEM(tuple, pos)) with
PyTuple_GetItemRef(tuple, pos).
@vstinner
Copy link
Member Author

The consensus is more towards documentation, rather than adding a new function.

@vstinner vstinner closed this Apr 19, 2024
@vstinner vstinner deleted the tuple_getitemref branch April 19, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou Awaiting requested review from encukou encukou will be requested when the pull request is marked ready for review encukou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin will be requested when the pull request is marked ready for review abalkin is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel will be requested when the pull request is marked ready for review iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra will be requested when the pull request is marked ready for review JelleZijlstra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner