gh-115775: Add whatsnew entry about __static_attributes__ #117909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
reviewed
Apr 15, 2024
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
|
Thanks for the description! I'm not sure what the use case is for adding this as public API. But since it is exposed, I guess it should also be added to the list of special attributes. (Sorry about the drip-feed of suggestions :( I'm not following the change closely -- I'm just reacting to the effect on projects tested with the latest alpha.) |
iritkatriel
commented
Apr 18, 2024
|
AFAIK, the missing definition should be added like this: iritkatriel#57 |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--117909.org.readthedocs.build/