Skip to content

gh-117518: Clarify PyTuple_GetItem() borrowed reference in the doc #117920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2024
Merged

gh-117518: Clarify PyTuple_GetItem() borrowed reference in the doc #117920

merged 2 commits into from
Apr 19, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 16, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Apr 16, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2024
Closed
@vstinner
Copy link
Member Author

cc @encukou

@vstinner vstinner mentioned this pull request Apr 16, 2024
Closed
@erlend-aasland
Copy link
Contributor

The return value is already emphasised as being a borrowed reference:

Screenshot 2024-04-16 at 10 15 59

It seems a bit strange to repeat this in the text below. Consider just adding the text that suggests the better approach.

erlend-aasland
erlend-aasland reviewed Apr 16, 2024
View reviewed changes
@vstinner
Copy link
Member Author

@erlend-aasland @encukou: I applied @erlend-aasland's suggestion.

@encukou encukou merged commit 4605a19 into python:main Apr 19, 2024
26 checks passed
@encukou encukou added the needs backport to 3.12 only security fixes label Apr 19, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2024
@vstinner @miss-islington
pythongh-117518: Clarify PyTuple_GetItem() borrowed reference in the …
ec70370 
…doc (pythonGH-117920)

(cherry picked from commit 4605a19)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Apr 19, 2024

GH-118087 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 19, 2024
@vstinner vstinner deleted the tuple_get_doc branch April 19, 2024 08:56
vstinner added a commit that referenced this pull request Apr 19, 2024
@miss-islington @vstinner
[3.12] gh-117518: Clarify PyTuple_GetItem() borrowed reference in the…
15be34a 
… doc (GH-117920) (#118087)

gh-117518: Clarify PyTuple_GetItem() borrowed reference in the doc (GH-117920)
(cherry picked from commit 4605a19)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @erlend-aasland @encukou