Skip to content

gh-118023: Fix reference leak #118025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024
Merged

gh-118023: Fix reference leak #118025

merged 1 commit into from
Apr 18, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Apr 18, 2024

@Eclips4
Copy link
Member Author

Eclips4 commented Apr 18, 2024

Before this PR:

./python.exe -m test -R 3:3 test_compile
Using random seed: 114949622
0:00:00 load avg: 4.27 Run 1 test sequentially
0:00:00 load avg: 4.27 [1/1] test_compile
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX4 444
test_compile leaked [2, 2, 2] references, sum=6
test_compile leaked [4, 4, 4] memory blocks, sum=12
test_compile failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_compile

Total duration: 12.2 sec
Total tests: run=164 skipped=1
Total test files: run=1/1 failed=1
Result: FAILURE

After this PR:

./python.exe -m test -R 3:3 test_compile
Using random seed: 1010092619
0:00:00 load avg: 3.37 Run 1 test sequentially
0:00:00 load avg: 3.37 [1/1] test_compile
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX. ...

== Tests result: SUCCESS ==

1 test OK.

Total duration: 12.3 sec
Total tests: run=164 skipped=1
Total test files: run=1/1
Result: SUCCESS

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iritkatriel iritkatriel enabled auto-merge (squash) April 18, 2024 07:09
@iritkatriel iritkatriel merged commit cd7cf15 into python:main Apr 18, 2024
@Eclips4 Eclips4 deleted the issue-118023 branch April 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants