Skip to content

devcontainer: update to Fedora 40 #118161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

devcontainer: update to Fedora 40 #118161

merged 1 commit into from
Apr 24, 2024

Conversation

rindeal
Copy link
Contributor

@rindeal rindeal commented Apr 22, 2024

Fedora 37 has been EOL since December last year, 38 is going to be EOL in May.

Tested it and no further changes seem necessary.

@bedevere-app
Copy link

bedevere-app bot commented Apr 22, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

corona10
corona10 reviewed Apr 23, 2024
View reviewed changes
@rindeal
devcontainer: update to Fedora 40
ed7d4ba 
37 has been EOL since December last year,
38 is going to be EOL in a month or so,
39 is current stable version,
40 was released today.
@rindeal rindeal force-pushed the devcontainer-fedora branch from 86435b3 to ed7d4ba Compare April 23, 2024 13:19
@bedevere-app
Copy link

bedevere-app bot commented Apr 23, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

savannahostrowski
savannahostrowski approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is great! I was actually about to open this same PR since 1) the whole EOL timeline on Fedora 37/38 + the big 40 announcement, and 2) we need a later version of clang to build with the JIT enabled.

Looks like the PR title doesn't match the version you're updating to (39 vs. 40) but that's a nit :)

@brandtbucher brandtbucher changed the title devcontainer: update to Fedora 39 devcontainer: update to Fedora 40 Apr 23, 2024
corona10
corona10 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I will merge this PR after testing in my local environment.

savannahostrowski
savannahostrowski requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have retested this earlier but it looks like I'm running into a make error when I try to update to Fedora 40, on updateContentCommand in the devcontainer.json.

Are you not seeing an error?

Specifically, this is failing:

"docs": [
            "make",
            "--directory",
            "Doc",
            "venv",
            "html"
        ]

@rindeal
Copy link
Contributor Author

rindeal commented Apr 24, 2024

Are you not seeing this error?

No.

Log 
[root@codespaces-99850f python--cpython--work-copy]# cat /etc/os-release 
NAME="Fedora Linux"
VERSION="40 (Container Image)"
ID=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux 40 (Container Image)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f40/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=40
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=40
SUPPORT_END=2025-05-13
VARIANT="Container Image"
VARIANT_ID=container
[root@codespaces-99850f python--cpython--work-copy]# make --directory Doc clean
make: Entering directory '/workspaces/python--cpython--work-copy/Doc'
rm -rf ./venv
rm -rf build/*
make: Leaving directory '/workspaces/python--cpython--work-copy/Doc'
[root@codespaces-99850f python--cpython--work-copy]# make --directory Doc venv html
make: Entering directory '/workspaces/python--cpython--work-copy/Doc'
Creating venv in ./venv
Requirement already satisfied: pip in ./venv/lib64/python3.12/site-packages (23.3.2)
Collecting pip
  Using cached pip-24.0-py3-none-any.whl.metadata (3.6 kB)
Using cached pip-24.0-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 23.3.2
    Uninstalling pip-23.3.2:
      Successfully uninstalled pip-23.3.2
Successfully installed pip-24.0
Collecting sphinx~=7.2.0 (from -r requirements.txt (line 9))
  Using cached sphinx-7.2.6-py3-none-any.whl.metadata (5.9 kB)
Collecting blurb (from -r requirements.txt (line 11))
  Using cached blurb-1.1.0-py3-none-any.whl.metadata (9.7 kB)
Collecting sphinx-autobuild (from -r requirements.txt (line 13))
  Using cached sphinx_autobuild-2024.4.16-py3-none-any.whl.metadata (7.7 kB)
Collecting sphinxext-opengraph==0.7.5 (from -r requirements.txt (line 14))
  Using cached sphinxext_opengraph-0.7.5-py3-none-any.whl.metadata (6.2 kB)
Collecting sphinx-notfound-page==1.0.0 (from -r requirements.txt (line 15))
  Using cached sphinx_notfound_page-1.0.0-py3-none-any.whl.metadata (2.9 kB)
Collecting python-docs-theme!=2023.7,>=2023.3.1 (from -r requirements.txt (line 19))
  Using cached python_docs_theme-2024.4-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-applehelp (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_applehelp-1.0.8-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-devhelp (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_devhelp-1.0.6-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-jsmath (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl.metadata (1.4 kB)
Collecting sphinxcontrib-htmlhelp>=2.0.0 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_htmlhelp-2.0.5-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-serializinghtml>=1.1.9 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_serializinghtml-1.1.10-py3-none-any.whl.metadata (2.4 kB)
Collecting sphinxcontrib-qthelp (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached sphinxcontrib_qthelp-1.0.7-py3-none-any.whl.metadata (2.2 kB)
Collecting Jinja2>=3.0 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached Jinja2-3.1.3-py3-none-any.whl.metadata (3.3 kB)
Collecting Pygments>=2.14 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached pygments-2.17.2-py3-none-any.whl.metadata (2.6 kB)
Collecting docutils<0.21,>=0.18.1 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached docutils-0.20.1-py3-none-any.whl.metadata (2.8 kB)
Collecting snowballstemmer>=2.0 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached snowballstemmer-2.2.0-py2.py3-none-any.whl.metadata (6.5 kB)
Collecting babel>=2.9 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached Babel-2.14.0-py3-none-any.whl.metadata (1.6 kB)
Collecting alabaster<0.8,>=0.7 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached alabaster-0.7.16-py3-none-any.whl.metadata (2.9 kB)
Collecting imagesize>=1.3 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached imagesize-1.4.1-py2.py3-none-any.whl.metadata (1.5 kB)
Collecting requests>=2.25.0 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached requests-2.31.0-py3-none-any.whl.metadata (4.6 kB)
Collecting packaging>=21.0 (from sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached packaging-23.2-py3-none-any.whl.metadata (3.2 kB)
Collecting colorama (from sphinx-autobuild->-r requirements.txt (line 13))
  Using cached colorama-0.4.6-py2.py3-none-any.whl.metadata (17 kB)
Collecting starlette>=0.35 (from sphinx-autobuild->-r requirements.txt (line 13))
  Using cached starlette-0.37.2-py3-none-any.whl.metadata (5.9 kB)
Collecting uvicorn>=0.25 (from sphinx-autobuild->-r requirements.txt (line 13))
  Using cached uvicorn-0.29.0-py3-none-any.whl.metadata (6.3 kB)
Collecting watchfiles>=0.20 (from sphinx-autobuild->-r requirements.txt (line 13))
  Using cached watchfiles-0.21.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.9 kB)
Collecting websockets>=11 (from sphinx-autobuild->-r requirements.txt (line 13))
  Using cached websockets-12.0-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (6.6 kB)
Collecting MarkupSafe>=2.0 (from Jinja2>=3.0->sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached MarkupSafe-2.1.5-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.0 kB)
Collecting charset-normalizer<4,>=2 (from requests>=2.25.0->sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached charset_normalizer-3.3.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (33 kB)
Collecting idna<4,>=2.5 (from requests>=2.25.0->sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached idna-3.7-py3-none-any.whl.metadata (9.9 kB)
Collecting urllib3<3,>=1.21.1 (from requests>=2.25.0->sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached urllib3-2.2.1-py3-none-any.whl.metadata (6.4 kB)
Collecting certifi>=2017.4.17 (from requests>=2.25.0->sphinx~=7.2.0->-r requirements.txt (line 9))
  Using cached certifi-2024.2.2-py3-none-any.whl.metadata (2.2 kB)
Collecting anyio<5,>=3.4.0 (from starlette>=0.35->sphinx-autobuild->-r requirements.txt (line 13))
  Using cached anyio-4.3.0-py3-none-any.whl.metadata (4.6 kB)
Collecting click>=7.0 (from uvicorn>=0.25->sphinx-autobuild->-r requirements.txt (line 13))
  Using cached click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
Collecting h11>=0.8 (from uvicorn>=0.25->sphinx-autobuild->-r requirements.txt (line 13))
  Using cached h11-0.14.0-py3-none-any.whl.metadata (8.2 kB)
Collecting sniffio>=1.1 (from anyio<5,>=3.4.0->starlette>=0.35->sphinx-autobuild->-r requirements.txt (line 13))
  Using cached sniffio-1.3.1-py3-none-any.whl.metadata (3.9 kB)
Using cached sphinxext_opengraph-0.7.5-py3-none-any.whl (9.2 kB)
Using cached sphinx_notfound_page-1.0.0-py3-none-any.whl (8.1 kB)
Using cached sphinx-7.2.6-py3-none-any.whl (3.2 MB)
Using cached blurb-1.1.0-py3-none-any.whl (22 kB)
Using cached sphinx_autobuild-2024.4.16-py3-none-any.whl (11 kB)
Using cached python_docs_theme-2024.4-py3-none-any.whl (19 kB)
Using cached alabaster-0.7.16-py3-none-any.whl (13 kB)
Using cached Babel-2.14.0-py3-none-any.whl (11.0 MB)
Using cached docutils-0.20.1-py3-none-any.whl (572 kB)
Using cached imagesize-1.4.1-py2.py3-none-any.whl (8.8 kB)
Using cached Jinja2-3.1.3-py3-none-any.whl (133 kB)
Using cached packaging-23.2-py3-none-any.whl (53 kB)
Using cached pygments-2.17.2-py3-none-any.whl (1.2 MB)
Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Using cached snowballstemmer-2.2.0-py2.py3-none-any.whl (93 kB)
Using cached sphinxcontrib_htmlhelp-2.0.5-py3-none-any.whl (99 kB)
Using cached sphinxcontrib_serializinghtml-1.1.10-py3-none-any.whl (92 kB)
Using cached starlette-0.37.2-py3-none-any.whl (71 kB)
Using cached uvicorn-0.29.0-py3-none-any.whl (60 kB)
Using cached watchfiles-0.21.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.3 MB)
Using cached websockets-12.0-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (131 kB)
Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Using cached sphinxcontrib_applehelp-1.0.8-py3-none-any.whl (120 kB)
Using cached sphinxcontrib_devhelp-1.0.6-py3-none-any.whl (83 kB)
Using cached sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl (5.1 kB)
Using cached sphinxcontrib_qthelp-1.0.7-py3-none-any.whl (89 kB)
Using cached anyio-4.3.0-py3-none-any.whl (85 kB)
Using cached certifi-2024.2.2-py3-none-any.whl (163 kB)
Using cached charset_normalizer-3.3.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (141 kB)
Using cached click-8.1.7-py3-none-any.whl (97 kB)
Using cached h11-0.14.0-py3-none-any.whl (58 kB)
Using cached idna-3.7-py3-none-any.whl (66 kB)
Using cached MarkupSafe-2.1.5-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (28 kB)
Using cached urllib3-2.2.1-py3-none-any.whl (121 kB)
Using cached sniffio-1.3.1-py3-none-any.whl (10 kB)
Installing collected packages: snowballstemmer, websockets, urllib3, sphinxcontrib-serializinghtml, sphinxcontrib-qthelp, sphinxcontrib-jsmath, sphinxcontrib-htmlhelp, sphinxcontrib-devhelp, sphinxcontrib-applehelp, sniffio, python-docs-theme, Pygments, packaging, MarkupSafe, imagesize, idna, h11, docutils, colorama, click, charset-normalizer, certifi, blurb, babel, alabaster, uvicorn, requests, Jinja2, anyio, watchfiles, starlette, sphinx, sphinxext-opengraph, sphinx-notfound-page, sphinx-autobuild
Successfully installed Jinja2-3.1.3 MarkupSafe-2.1.5 Pygments-2.17.2 alabaster-0.7.16 anyio-4.3.0 babel-2.14.0 blurb-1.1.0 certifi-2024.2.2 charset-normalizer-3.3.2 click-8.1.7 colorama-0.4.6 docutils-0.20.1 h11-0.14.0 idna-3.7 imagesize-1.4.1 packaging-23.2 python-docs-theme-2024.4 requests-2.31.0 sniffio-1.3.1 snowballstemmer-2.2.0 sphinx-7.2.6 sphinx-autobuild-2024.4.16 sphinx-notfound-page-1.0.0 sphinxcontrib-applehelp-1.0.8 sphinxcontrib-devhelp-1.0.6 sphinxcontrib-htmlhelp-2.0.5 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.7 sphinxcontrib-serializinghtml-1.1.10 sphinxext-opengraph-0.7.5 starlette-0.37.2 urllib3-2.2.1 uvicorn-0.29.0 watchfiles-0.21.0 websockets-12.0
The venv has been created in the ./venv directory
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -j auto   -W . build/html 
Running Sphinx v7.2.6
making output directory... done
building [mo]: targets for 0 po files that are out of date
writing output... 
building [html]: targets for 467 source files that are out of date
updating environment: [new config] 467 added, 0 changed, 0 removed
reading sources... [100%] tutorial/stdlib2 .. whatsnew/index
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
                  copying downloadable files... [100%] includes/tzinfo_examples.py
copying static files... done
copying extra files... done
done
writing output... [100%] reference/executionmodel .. whatsnew/index
generating indices... genindex py-modindex done
writing additional pages... download index search opensearch done
copying images... [100%] using/win_install_freethreaded.png
dumping search index in English (code: en)... done
dumping object inventory... done
Writing glossary.json
build succeeded.

The HTML pages are in build/html.

Build finished. The HTML pages are in build/html.
make: Leaving directory '/workspaces/python--cpython--work-copy/Doc'

savannahostrowski
savannahostrowski approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think that my VS Code install is broken. I ended up testing both in a fresh Codespaces instance and a local dev container with VS Code insiders and managed to get everything working as expected. LGTM.

@corona10
Copy link
Member

I am merging this PR, thank you for the cross-checking @savannahostrowski

@corona10 corona10 merged commit f6e5cc6 into python:main Apr 24, 2024
37 checks passed
@rindeal rindeal deleted the devcontainer-fedora branch April 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok left review comments

@corona10 corona10 corona10 approved these changes

@savannahostrowski savannahostrowski savannahostrowski approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rindeal @corona10 @hroncok @savannahostrowski