[3.12] gh-118207: Rename the COMMON_FIELDS macro in funcobject.h and undef it after use (GH-118208) #118269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndef it after use (pythonGH-118208) (cherry picked from commit 796b3fb) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This was referenced Apr 25, 2024
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Apr 26, 2024
…nd undef it after use Summary: supersedes D56454529 by backporting the upstream version instead of an internal patch upstream issue: python/cpython#118207 upstream PR: python/cpython#118269 still undef'ing the macro, but also renaming it to have `_Py` prefix, for consistency, and to avoid conflicts if the same name is already defined before including `Python.h` Reviewed By: aleivag Differential Revision: D56579827 fbshipit-source-id: c8260818f5901bc9c3eb582999575af9c64f189f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 796b3fb)
Co-authored-by: Itamar Oren itamarost@gmail.com