-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-117657: Don't specialize RESUME_CHECK when specialization is disabled #118349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but it might make sense to change the title to something like "Don't specialize RESUME_CHECK when specialization is disabled", which is what this is really doing. It's a good fix independent of free-threading concerns.
@DinoV made this atomic but we should still disable this if specialization is off anyways, for consistency's sake. |
|
It was showing up as a race in tsan. Though other races still bubble up with vectorcall so we cant remove it from the ignore list for now.