gh-118476: update the example implementation for islice in docs #118466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The previous version was needlessly complicated * It was also wrong since it overwrote stop == 0 to maxsize
|
All commit authors signed the Contributor License Agreement. |
nineteendo
reviewed
May 3, 2024
Comment on lines
+516
to
+517
| for i, element in enumerate(it, start): | ||
| if (i - start) % step == 0: |
There was a problem hiding this comment.
Is it worth adding this comment here?
Suggested change
| for i, element in enumerate(it, start): | |
| if (i - start) % step == 0: | |
| for i, element in enumerate(it, start): | |
| # Consume to *stop*. | |
| if (i - start) % step == 0: |
|
Closing this because a much improved version was found by Stefan Pochmann. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looked like it returned
[1,2,3]rather than[].Fixes #118476
📚 Documentation preview 📚: https://cpython-previews--118466.org.readthedocs.build/