-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-118164: str(10**10000) hangs if the C _decimal module is missing #118503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
620acaa
Initial stab.
tim-one 961e08a
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one 97319ee
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one ecf1394
Test the tentative fix. Hangs "forever" without this change.
tim-one b4c6143
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one 3e9417d
Move the new test to a better spot.
tim-one bf52ed4
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one d22f152
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one bb8f4ed
New comment to explain why _convert_to_str allows any poewr of 10.
tim-one a73b811
Fixed a comment, and fleshed out an existing test that appeared unfin…
tim-one 96bbd1b
Merge branch 'main' into pydec2
tim-one e45a0b0
Added temporary asserts. Or maybe permanent ;-)
tim-one 8f95bae
Update Lib/_pydecimal.py
tim-one a616611
Merge remote-tracking branch 'upstream/main' into pydec2
tim-one 65bced3
Remove the new _convert_to_str().
tim-one 2b8f377
At least for now, add the asserts to the other block too.
tim-one 1b584eb
📜🤖 Added by blurb_it.
blurb-it[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2024-05-04-20-22-59.gh-issue-118164.9D02MQ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
The Python implementation of the ``decimal`` module could appear to hang in relatively small power cases (like ``2**117``) if context precision was set to a very high value. A different method to check for exactly representable results is used now that doesn't rely on computing ``10**precision`` (which could be effectively too large to compute). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.