-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
gh-118476: Fix corner cases in islice() rough equivalent. #118559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now passes these tests which were commented out above:
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2024
…onGh-118559) (cherry picked from commit c7c9b91) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2024
…onGh-118559) (cherry picked from commit c7c9b91) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
GH-118587 is a backport of this pull request to the 3.12 branch. |
GH-118588 is a backport of this pull request to the 3.11 branch. |
rhettinger
pushed a commit
that referenced
this pull request
May 5, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the corner case errors reported by F H T Mitchell, "This does not correctly handle stop == 0, overwriting it to be sys.maxsize and also assumes its input is an iterator, not any iterable."
The elegant and readable code rough equivalent was crafted by Stefan Pochmann.
This mostly passes all the tests for the C version of islice() except:
This is deemed good enough for a rough equivalent that aims to convey how the stream of indices is created when correct inputs are supplied.
Here are the tests I applied to the rough equivalent (taken from
Lib/test/test_itertools.py
and from the bug report):📚 Documentation preview 📚: https://cpython-previews--118559.org.readthedocs.build/