Skip to content

gh-118362: Skip tests when threading isn't available #118666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2024

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented May 6, 2024

#118454 introduced failures on iOS. Switches to a more general way of skipping tests when threading isn't available.

@colesbury
Copy link
Contributor

!buildbot ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit ff5a757 🤖

The command will test the builders whose names match following regular expression: ios

The builders matched are:

  • iOS ARM64 Simulator PR

@DinoV DinoV force-pushed the nogil_skip_tests branch from 140ff4a to db233a3 Compare May 6, 2024 21:58
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version with ThreadPoolExecutor and requires_working_threading looks good to me (for the iOS case, anyway).

@DinoV DinoV merged commit e272195 into python:main May 6, 2024
32 checks passed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
…8666)

* Skip tests when threads aren't available

* Use ThreadPoolExecutor
@DinoV DinoV deleted the nogil_skip_tests branch May 31, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants