Skip to content

[3.12] gh-119049: Fix incorrect display of warning which is constructed by C API (GH-119063) #119119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 17, 2024

The source line was not displayed if the warnings module had not yet been imported.

…d by C API (pythonGH-119063)

The source line was not displayed if the warnings module had not yet
been imported.
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm, the tests are passed with the unmodified code. Does it mean that the issue did not exist in 3.12 or that it was reproducible only when pass the code as a string in 3.13?

@Eclips4
Copy link
Member Author

Eclips4 commented May 17, 2024

Humm, the tests are passed with the unmodified code. Does it mean that the issue did not exist in 3.12 or that it was reproducible only when pass the code as a string in 3.13?

Indeed, the issue only occurs when passing the code as a string in 3.13+ versions. Backporting this pull request to 3.12 makes no sense, so I'm going to close it.

@Eclips4 Eclips4 closed this May 17, 2024
@Eclips4 Eclips4 deleted the issue-119049-312 branch May 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants