gh-119562: Remove AST nodes deprecated since Python 3.8 #119563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
May 25, 2024
AraHaan
reviewed
May 26, 2024
| @@ -508,27 +508,6 @@ def generic_visit(self, node): | |||
| elif isinstance(value, AST): | |||
| self.visit(value) | |||
|
|
|||
| def visit_Constant(self, node): | |||
There was a problem hiding this comment.
Uh I think you accidentally removed this. Above said to use this. 😄
There was a problem hiding this comment.
I deliberately removed it. It will still work if you define visit_Constant on a custom subclass of ast.NodeVisitor. The reason why it is currently defined on ast.NodeVisitor itself — uniquely among the visit_* methods — is to ensure that the deprecated methods visit_Num, visit_Str, etc. continue to work if you define them on a subclass of ast.NodeVisitor.
There was a problem hiding this comment.
I tried to clarify this a bit in 40b5965 -- hopefully that helps!
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
luk1337
added a commit
to luk1337/weechat
that referenced
this pull request
Oct 30, 2024
luk1337
added a commit
to luk1337/weechat
that referenced
this pull request
Oct 30, 2024
flashcode
pushed a commit
to weechat/weechat
that referenced
this pull request
Nov 4, 2024
flashcode
pushed a commit
to weechat/weechat
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119562
📚 Documentation preview 📚: https://cpython-previews--119563.org.readthedocs.build/