Skip to content

Fix grammar error in timeit module docs #12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix grammar error in timeit module docs #12066

merged 1 commit into from
Feb 27, 2019

Conversation

shivdhar
Copy link
Contributor

@shivdhar shivdhar commented Feb 27, 2019 •
edited
Loading

skip issue
skip news

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 27, 2019
eamanu
eamanu approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a fix typo. news and issue could be skipped.

@shivdhar, please sign CLA.

@shivdhar
Copy link
Contributor Author

Hi, I did sign the agreement using my Google OpenId username(shown as my b.p.o "Login Name") but apparently I haven't? Should I re-sign it using my GitHub username?

@miss-islington miss-islington merged commit 4064089 into python:master Feb 27, 2019
@miss-islington
Copy link
Contributor

Thanks @shivdhar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2019
@shivdhar @miss-islington
Fix grammar error in timeit module docs (pythonGH-12066)
5c57e6e 
skip issue
skip news
(cherry picked from commit 4064089)

Co-authored-by: Shiv Dhar <shivdhar@gmail.com>
@bedevere-bot
Copy link

GH-12082 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 27, 2019
@miss-islington @shivdhar
Fix grammar error in timeit module docs (GH-12066)
79e7259 
skip issue
skip news
(cherry picked from commit 4064089)

Co-authored-by: Shiv Dhar <shivdhar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shivdhar @the-knights-who-say-ni @miss-islington @bedevere-bot @ned-deily @eamanu