Skip to content

bpo-36121: Override field_size_limit per csv.reader object #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-36121: Override field_size_limit per csv.reader object #12071

wants to merge 2 commits into from
+135 −17

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Feb 27, 2019 •
edited by bedevere-bot
Loading

@remilapeyre remilapeyre force-pushed the override-csv.field_size_limit branch 2 times, most recently from b10f1dc to be2a5ec Compare February 27, 2019 16:09
@remilapeyre remilapeyre force-pushed the override-csv.field_size_limit branch from be2a5ec to f2d530f Compare February 27, 2019 16:10
ZackerySpytz
ZackerySpytz reviewed Dec 29, 2019
View reviewed changes
Copy link
Contributor

@ZackerySpytz ZackerySpytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this feature will be accepted, but I have some comments.

@remilapeyre
Copy link
Contributor Author

Thanks, it took me a while but I made the changes you requested.

@vnmabus
Copy link

vnmabus commented Oct 28, 2021

I don't know the typical times for a PR like this one to be accepted, but if it helps to find the motivation to accept it, the original bug was submitted because of this conversation in the Scipy repository: scipy/scipy#9854 (comment)

MaxwellDupre
MaxwellDupre approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run of test_csv:
Ran 107 tests in 0.327s
OK
It would be good to add in csv.rst:
Changed in version 3.12

@CarlosRamos CarlosRamos mannequin mentioned this pull request Apr 10, 2022
Open
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@remilapeyre @vnmabus @MaxwellDupre @ZackerySpytz @the-knights-who-say-ni @ezio-melotti @bedevere-bot