[3.6] Document the surprising sideeffect PyErr_Print(). (GH-12081) #12084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you know an API documented as printing the pending traceback would sometimes exit the process? You do now. (cherry picked from commit 4173772) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
doc change, up to Ned (RM) if this goes into the 3.6 tree or not. no big deal, people will refer to 3.latest docs online. |
|
@gpshead: Status check is done, and it's a success ✅ . |
|
In general, our policy is to not backport doc fixes to branches in security-fix-only mode (it's even in the name!). I believe the main reason for the policy was to simplify the workload for core developers. Now that we have Miss Islington to help, perhaps the policy could be re-examined. But until it is, I would prefer that we follow it. OTOH, since Miss I has already done the heavy lifting for this one ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you know an API documented as printing the pending traceback would sometimes exit the process?
You do now.
(cherry picked from commit 4173772)
Co-authored-by: Gregory P. Smith greg@krypto.org