gh-120155: Fix Coverity issue in parse_string() #120997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an assertion to make sure that the 'len' variable is at least 1,
to make sure that the code '--len' below is safe.
Fix the Coverity issue on Python-3.12.2:
Error: INTEGER_OVERFLOW (CWE-190):
Parser/string_parser.c:236:5: underflow: The decrement operator on
the unsigned variable "len" might result in an underflow.
Parser/string_parser.c:246:9: overflow: The expression "len -= 2UL"
is deemed underflowed because at least one of its arguments has
underflowed.
Parser/string_parser.c:269:13: overflow_sink: "len", which might
have underflowed, is passed to
"PyBytes_FromStringAndSize(s, len)".
267| }
268| if (rawmode) {
269|-> return PyBytes_FromStringAndSize(s, len);
270| }
271| return decode_bytes_with_escapes(p, s, len, t);
lysnikolaou
approved these changes
Jun 25, 2024
|
Thanks @vstinner for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2024
(cherry picked from commit 769aea3) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2024
(cherry picked from commit 769aea3) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-121005 is a backport of this pull request to the 3.13 branch. |
|
GH-121006 is a backport of this pull request to the 3.12 branch. |
vstinner
added a commit
that referenced
this pull request
Jun 25, 2024
vstinner
added a commit
that referenced
this pull request
Jun 25, 2024
|
Thank you for reviews! |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an assertion to make sure that the 'len' variable is at least 1, to make sure that the code '--len' below is safe.
Fix the Coverity issue on Python-3.12.2:
Error: INTEGER_OVERFLOW (CWE-190):
Parser/string_parser.c:236:5: underflow: The decrement operator on
the unsigned variable "len" might result in an underflow.
Parser/string_parser.c:246:9: overflow: The expression "len -= 2UL"
is deemed underflowed because at least one of its arguments has
underflowed.
Parser/string_parser.c:269:13: overflow_sink: "len", which might
have underflowed, is passed to
"PyBytes_FromStringAndSize(s, len)".
267| }
268| if (rawmode) {
269|-> return PyBytes_FromStringAndSize(s, len);
270| }
271| return decode_bytes_with_escapes(p, s, len, t);