Skip to content

gh-121272: move __future__ import validation from compiler to symtable #121273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

gh-121272: move __future__ import validation from compiler to symtable #121273

merged 2 commits into from
Jul 2, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 2, 2024
Closed
AraHaan
AraHaan approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@AraHaan AraHaan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this could be a good performance improvement when using a ton of c extensions with python scripts that use import from statements on them.

picnixz
picnixz reviewed Jul 2, 2024
View reviewed changes
@iritkatriel @picnixz
PEP 7
1661310 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@iritkatriel
Copy link
Member Author

I agree, this could be a good performance improvement when using a ton of c extensions with python scripts that use import from statements on them.

This shouldn't impact performance.

This is about simplifying code in compile.c (in this case, making compiler_from_import no longer access the internals of struct compiler). This is part of a longer term plan to break up the compiler.

JelleZijlstra
JelleZijlstra approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is thoroughly tested in test_future_stmt/test_future.py and I confirmed that the code in future.c that sets ff_location makes sense.

@iritkatriel iritkatriel enabled auto-merge (squash) July 2, 2024 16:14
@iritkatriel iritkatriel merged commit 1ac2732 into python:main Jul 2, 2024
37 checks passed
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@iritkatriel @Akasurde
pythongh-121272: move __future__ import validation from compiler to s…
f767f75 
…ymtable (python#121273)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@iritkatriel @noahbkim
pythongh-121272: move __future__ import validation from compiler to s…
c13f87f 
…ymtable (python#121273)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@iritkatriel @estyxx
pythongh-121272: move __future__ import validation from compiler to s…
fb74b85 
…ymtable (python#121273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AraHaan AraHaan AraHaan approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @JelleZijlstra @picnixz @AraHaan