-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-121306: allow a mapping as __dict__ of object #121389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blhsing
wants to merge
50
commits into
python:main
Choose a base branch
from
blhsing:allow-mapping-as-globals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+482
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ and function.__globals__; added macros for unified dict/mapping API
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a mapping as the
__dict__
attribute of an object. This was originally meant to allow a mapping to be passed as the globals argument toexec
andeval
, but for consistency the global namespace of a module should be allowed to be a mapping as well, and by extension the__dict__
attribute of any object.Full backwards compatibility is maintained by adding a
PyDict_Check
-guarded fast path to existingPyDict_*
function calls with a fallback to theirPyMapping_*
equivalent API calls. A unified dict/mapping API in the form of helper macros is introduced to avoid potential code clutter from adding such a conditional statement to everyPyDict_*
call.Note that some
PyDict_*
functions do not have directPyMapping_*
equivalents so calls to those functions have to be switched to similar functions that do havePyMapping_*
equivalents. These include:PyDict_Pop(dict, key, NULL)
is replaced withPyDict_DelItem(dict, key)
; the former does not raiseKeyError
while the latter does, so the caller has to handle error differently.PyDict_GetItemWithError
is replaced withPyDict_GetItemRef
; the former returns a borrowed reference while the latter creates a new ref so the caller has to account for the new ref accordingly.Tests that expected
SystemError
orTypeError
from a non-dict global namspace have been revised to reflect the new capability.exec
with aChainMap
) #121306