Skip to content

gh-121249: Support _Complex types in the struct module #121613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 7, 2024
Merged

gh-121249: Support _Complex types in the struct module #121613

merged 12 commits into from
Oct 7, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Jul 11, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 11, 2024
Open
ZeroIntensity
ZeroIntensity requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! This looks like something that would have had to get approved on Discourse, though.

@skirpichev @ZeroIntensity
Apply suggestions from code review
3aac6d1 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
skirpichev

This comment was marked as outdated.

Sign in to view

@ZeroIntensity
Copy link
Member

Lets leave this to core devs.

This is why things get discussed on discourse first 😉

skirpichev
skirpichev commented Jul 12, 2024
View reviewed changes
skirpichev
skirpichev commented Jul 12, 2024
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation LGTM.

Although, for core dev review, I'm not too sure about this behavior: if the compiler does not support C11 complex types, then the new format characters are disabled and raise an error with no further information.

I'm worried that this will lead to some bug reports later on wondering why E and C don't work on their system -- it would be ideal to raise a different error mentioning that the system doesn't support C11 (albeit, it would be more work to implement).

picnixz
picnixz reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but I also agree that having an error without info for an unknown format if complex are not supported is a bit weird.

@skirpichev skirpichev force-pushed the complex-in-struct-module-121249 branch from 7806d52 to fec6be6 Compare July 13, 2024 04:12
@skirpichev
Copy link
Member Author

Now on systems without _Complex type - a different error will be raised.

picnixz
picnixz reviewed Jul 13, 2024
View reviewed changes
picnixz
picnixz approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side it's fine. I didn't check in details the functions bodies, but I assume that the tests should cover most of the cases. I think it remains to wait for Victor's and/or Serhiy's review.

@skirpichev
Copy link
Member Author

As it's a follow up of #120894, CC @vstinner

vstinner
vstinner reviewed Oct 7, 2024
View reviewed changes
@skirpichev skirpichev requested a review from vstinner October 7, 2024 10:23
vstinner
vstinner approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 7487db4 into python:main Oct 7, 2024
39 checks passed
@vstinner
Copy link
Member

vstinner commented Oct 7, 2024

Merged, thanks.

@skirpichev skirpichev deleted the complex-in-struct-module-121249 branch October 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@picnixz picnixz picnixz approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @ZeroIntensity @vstinner @picnixz