Skip to content

[3.6] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) #12165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.6] bpo-36179: Fix ref leaks in _hashopenssl (GH-12158) #12165

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 4, 2019 •
edited by bedevere-bot
Loading

Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue36179.
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue36179

@tiran
[3.6] bpo-36179: Fix ref leaks in _hashopenssl (pythonGH-12158)
78f104f 
Fix two unlikely reference leaks in _hashopenssl. The leaks only occur in
out-of-memory cases. Thanks to Charalampos Stratakis.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue36179.
(cherry picked from commit b7bc283)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Mar 4, 2019
Merged
vstinner
vstinner approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@vstinner
Copy link
Member

vstinner commented Mar 4, 2019

Oh sorry, 3.6 doesn't accept bugfixes anymore. You should close your PR, @tiran.

@tiran tiran added the invalid label Mar 4, 2019
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@tiran
Copy link
Member Author

tiran commented Mar 4, 2019

3.6 branch is in security-only mode. Closing

@tiran tiran closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot