Skip to content

[3.13] gh-121605: Increase timeout in test_pyrepl.run_repl (GH-121606) #121702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2024
Merged

[3.13] gh-121605: Increase timeout in test_pyrepl.run_repl (GH-121606) #121702

merged 1 commit into from
Jul 13, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

We also need to close the slave_fd earlier so that reading from
master_fd won't block forever when the subprocess finishes.
(cherry picked from commit abc3aee)

Co-authored-by: Sam Gross colesbury@gmail.com

@colesbury @miss-islington
pythongh-121605: Increase timeout in test_pyrepl.run_repl (pythonGH-1…
9f47df9 
…21606)

We also need to close the `slave_fd` earlier so that reading from
`master_fd` won't block forever when the subprocess finishes.
(cherry picked from commit abc3aee)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
@bedevere-app bedevere-app bot added skip news topic-repl Related to the interactive shell labels Jul 13, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Merged
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Jul 13, 2024
@colesbury colesbury merged commit 14c5bff into python:3.13 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miss-islington @colesbury