Skip to content

gh-121708: Improve test coverage for unittest.util #121713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

gh-121708: Improve test coverage for unittest.util #121713

merged 1 commit into from
Jul 14, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

Adds tests for safe_repr, sorted_list_difference and unorderable_list_difference.

Getting the coverage: ./python ../coveragepy run --pylib --branch --source=unittest Lib/test/regrtest.py test_unittest
To get the HTML report: ./python ../coveragepy/ html -i --include=pwd/Lib/* --omit="Lib/test/*,Lib/*/tests/*"

Before:

image
image
image

After:

image
image
image

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jul 13, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2024
Closed
encukou
encukou approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't documented, but they are publicly available, so it's better to have tests for them...

@encukou encukou merged commit 901ea41 into python:main Jul 14, 2024
36 checks passed
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 14, 2024
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@tomasr8 @miss-islington
pythongh-121708: Improve test coverage for unittest.util (pythonGH-…
62ed8e9 
…121713)

(cherry picked from commit 901ea41)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2024
@tomasr8 @miss-islington
pythongh-121708: Improve test coverage for unittest.util (pythonGH-…
4b875dd 
…121713)

(cherry picked from commit 901ea41)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121737 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 14, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2024

GH-121738 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2024
encukou pushed a commit that referenced this pull request Jul 14, 2024
@miss-islington @tomasr8
[3.13] gh-121708: Improve test coverage for unittest.util (GH-121713)…
e8594aa 
… (GH-121738)

(cherry picked from commit 901ea41)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
encukou pushed a commit that referenced this pull request Jul 14, 2024
@miss-islington @tomasr8
[3.12] gh-121708: Improve test coverage for unittest.util (GH-121713)…
98340a0 
… (GH-121737)

(cherry picked from commit 901ea41)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@tomasr8 tomasr8 deleted the unittest-utils-tests branch July 14, 2024 09:12
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@tomasr8 @estyxx
pythongh-121708: Improve test coverage for unittest.util (pythonGH-…
eb4421d 
…121713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasr8 @encukou