-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-109523: In _io_TextIOWrapper_read_impl skip decoding if bytes are None #121739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
giosiragusa
commented
Jul 14, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: sys.stdin.read() throws a TypeError when stdin is set to be non-blocking #109523
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
1 similar comment
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@@ -0,0 +1 @@ | |||
stdin.read() no longer throws a TypeError if no input is provided when stdin is set to non-blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdin.read() no longer throws a TypeError if no input is provided when stdin is set to non-blocking. | |
``sys.stdin.read()`` no longer throws a :exc:`TypeError` if no input is provided | |
when :data:`sys.stdin` is set to non-blocking. |
I'm wondering whether the change should only mention sys.stdin
or not. Here, it's for any TextIOWrapper
.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I'm closing this PR because was decide to return BlockingIOError instead than None |