gh-121610: pyrepl - handle extending blocks when multi-statement blocks are pasted #121757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
console.compile with the "single" param throws an exception when there are multiple statements, never allowing to adding newlines to a pasted code block (pythongh-121610) This add a few extra checks to allow extending when in an indented block, and tests for a few examples
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2024
…t blocks are pasted (pythonGH-121757) console.compile with the "single" param throws an exception when there are multiple statements, never allowing to adding newlines to a pasted code block (pythongh-121610) This add a few extra checks to allow extending when in an indented block, and tests for a few examples (cherry picked from commit 7d111da) Co-authored-by: saucoide <32314353+saucoide@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
GH-121825 is a backport of this pull request to the 3.13 branch. |
ambv
added a commit
that referenced
this pull request
Jul 16, 2024
…nt blocks are pasted (GH-121757) (GH-121825) console.compile with the "single" param throws an exception when there are multiple statements, never allowing to adding newlines to a pasted code block (gh-121610) This adds a few extra checks to allow extending when in an indented block, and tests for a few examples. (cherry picked from commit 7d111da) Co-authored-by: saucoide <32314353+saucoide@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
|
|
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…t blocks are pasted (pythonGH-121757) console.compile with the "single" param throws an exception when there are multiple statements, never allowing to adding newlines to a pasted code block (pythongh-121610) This add a few extra checks to allow extending when in an indented block, and tests for a few examples Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.compile with the "single" param throws an exception when there are multiple statements, never allowing to add newlines to a pasted code block (gh-121610)
This adds a few extra checks to allow extending when in an indented block, and tests for a few examples
I moved the function out of the outer one to be able to test it more easily, the tests check for what i think is the "expected" behavior for when to add a newline vs executing but please check me on that :)