gh-121834: Improve complex C-API docs
#121835
Merged
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
reviewed
Jul 16, 2024
|
The build failure is not related, see #121766 |
erlend-aasland
approved these changes
Jul 16, 2024
|
This looks fine: Thanks everyone! |
skirpichev
reviewed
Jul 16, 2024
encukou
reviewed
Jul 16, 2024
Co-authored-by: Petr Viktorin <encukou@gmail.com>
skirpichev
reviewed
Jul 16, 2024
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
Thanks everyone! |
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
GH-121895 is a backport of this pull request to the 3.13 branch. |
|
I will backport this to 3.12 manually. |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-121897 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @skirpichev
I unified exception messages for
NULLand-1.0cases separatelly.complexC-API error descriptions #121834📚 Documentation preview 📚: https://cpython-previews--121835.org.readthedocs.build/