Skip to content

GH-120024: Add verification tool to check for unmarked escaping calls #121917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

GH-120024: Add verification tool to check for unmarked escaping calls #121917

wants to merge 3 commits into from

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 17, 2024 •
edited by bedevere-app bot
Loading

Add tool to check for unmarked escaping calls.
Output looks like:

Unmarked escaping function '_Py_Instrument' at .../bytecodes.c:159
Unmarked escaping function '_Py_Instrument' at .../bytecodes.c:194
Unmarked escaping function '_Py_call_instrumentation' at .../bytecodes.c:204
Unmarked escaping function '_PyFrame_GetStackPointer' at .../bytecodes.c:206
Unmarked escaping function '_PyEval_FormatExcCheckArg' at .../bytecodes.c:223
...

Currently there are about 250 escaping calls in bytecodes.c
We will eventually turn this on in CI, once we've marked all the escaping calls.

@bedevere-app bedevere-app bot mentioned this pull request Jul 17, 2024
Open
@markshannon markshannon closed this Aug 6, 2024
@markshannon markshannon deleted the check-for-escapes branch August 6, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markshannon