-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[3.12] Merge Ubuntu test matrices in CI (GH-121813) #122116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
needs: check_source | ||
if: needs.check_source.outputs.run_tests == 'true' | ||
strategy: | ||
matrix: | ||
free-threading: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no free-threading in 3.12.
The Windows 3.12 backport included free-threading things in reusable-windows.yml but build.yml didn't mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... because the #121776 backport hasn't been merged yet :)
But that comments out the free-threading: true
job. Do the same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that comments out the
free-threading: true
job. Do the same here?
Yes! I forgot about that one, only fixed the merge conflicts. I left it commented out to facilitate any future backports, reducing possible conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why that doesn't fail the CI and saw this:
configure: WARNING: unrecognized options: --disable-gil
@hugovk any reason invalid flags don't crash the build process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out that matrix factor. Marking this thread as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why that doesn't fail the CI and saw this:
configure: WARNING: unrecognized options: --disable-gil
@hugovk any reason invalid flags don't crash the build process?
Let's ask @erlend-aasland
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>. (cherry picked from commit a3f7db9) Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
e1254a8
to
1d08251
Compare
Thanks! |
.
(cherry picked from commit a3f7db9)