[3.12] gh-113785: csv: fields starting with escapechar are not quoted (GH-122110) #122259
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-122110) (cherry picked from commit a3327db) Co-authored-by: Mikołaj Kuranowski <mkuranowski@gmail.com>
This was referenced Jul 25, 2024
|
@serhiy-storchaka This didn't automerge because ======================================================================
FAIL: test_read_quoting (test.test_csv.Test_Csv.test_read_quoting)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_csv.py", line 428, in test_read_quoting
self._read_test(['1\\.5,\\.5,.5'], [[1.5, 0.5, 0.5]],
File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_csv.py", line 354, in _read_test
self.assertEqual(result, expect)
AssertionError: Lists differ: [[1.5, '.5', 0.5]] != [[1.5, 0.5, 0.5]]
First differing element 0:
[1.5, '.5', 0.5]
[1.5, 0.5, 0.5]
- [[1.5, '.5', 0.5]]
? ^ -
+ [[1.5, 0.5, 0.5]]
? ^ |
482eb1c to
05e9bb7
Compare
|
Oh yes. It depended on #113732. It is possible to resolve this issue without touching that change. But It may be safer to not backport this change to 3.12. |
|
Oh, I did not mean to merge it now. Well, it doesn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a3327db)
Co-authored-by: Mikołaj Kuranowski mkuranowski@gmail.com