Skip to content

gh-67407: Improve IDLE Find, Replace and Find in Files dialogs #122394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Jul 29, 2024

Finished

The issue addressed by this PR is almost 10 years old. #67407 proposed some changes, but there are still some issues, such as the shortening of "regular expression" to "regex" not being accepted. The main issue addressed by this PR has not changed; most of it is about the proposed changes, and modifications have been made according to Terry's suggestions #67407 (comment)

Here are the before and after screenshots:
idle

IDLE is a program with a long history. Overall, this PR makes various changes to modernize the user interface of the Find, Replace, and Find in Files dialogs:

  • Got rid of the "close" button, since it is redundant.
  • Moved the buttons below the text fields, to make better use of screen real estate.
  • Shorten the titles by getting rid of the "Dialog" part.
  • Renamed "Search" title to "Find" to match the menu item.
  • Added slightly more padding.
  • Removed the "Replace+Find" and made "Replace" have this functionality. (all modern editors use Replace to mean "Replace and Find")
  • Change replace dialog button [ Find ] to [ Find Next ] (terry)Modernize the IDLE Find/Replace/Find in Files dialogs #67407 (comment)
    )

Others

Also see my another IDLE PR (Should be after this pr merge) #121420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant