Skip to content

gh-122445: populate only modified fields in __static_attributes__ #122446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 2, 2024
Merged

gh-122445: populate only modified fields in __static_attributes__ #122446

merged 14 commits into from
Aug 2, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 30, 2024 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added the needs backport to 3.13 bugs and security fixes label Jul 30, 2024
@iritkatriel iritkatriel requested a review from markshannon as a code owner July 30, 2024 10:42
@bedevere-app bedevere-app bot mentioned this pull request Jul 30, 2024
Closed
@iritkatriel iritkatriel changed the title gh-122445: include optimized method calls in __static_attributes__ gh-122445: populate only modified fields in __static_attributes__ Jul 31, 2024
iritkatriel
iritkatriel commented Jul 31, 2024
View reviewed changes
markshannon
markshannon reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks suggested, but looks good overall.

@iritkatriel iritkatriel merged commit 498376d into python:main Aug 2, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @iritkatriel, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 498376d7a7d6f704f22a2c963130cc15c17e7a6f 3.13

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 2, 2024
@iritkatriel
pythongh-122445: populate only modified fields in __static_attributes…
dbcd947 
…__ (python#122446)

(cherry picked from commit 498376d)
@bedevere-app
Copy link

bedevere-app bot commented Aug 2, 2024

GH-122621 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 2, 2024
iritkatriel added a commit that referenced this pull request Aug 2, 2024
@iritkatriel
[3.13] gh-122445: populate only modified fields in __static_attribute…
545a328 
…s__ (#122446) (#122621)

gh-122445: populate only modified fields in __static_attributes__ (#122446)

(cherry picked from commit 498376d)
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@iritkatriel @brandtbucher
pythongh-122445: populate only modified fields in __static_attributes…
90520b4 
…__ (python#122446)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@iritkatriel @blhsing
pythongh-122445: populate only modified fields in __static_attributes…
236908c 
…__ (python#122446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__static_attributes__ doesn't include method calls
3 participants
@iritkatriel @markshannon @Eclips4